test(cli): box lifecycle journey suite — surfaces logs/stdout gap#630
Open
G4614 wants to merge 1 commit into
Open
test(cli): box lifecycle journey suite — surfaces logs/stdout gap#630G4614 wants to merge 1 commit into
G4614 wants to merge 1 commit into
Conversation
G4614
force-pushed
the
fix/cp-into-runtime-mounts
branch
from
42e1bf1 to
a627541
Compare
…p-fills Five end-to-end tests in src/cli/tests/lifecycle_journey.rs that string the verbs a user actually types together as a composed flow rather than each in isolation. Centerpiece — box_full_user_journey_birth_to_death — walks one named box through pull → run -d → ps → exec → cp in → exec verify → exec mutate → cp out + byte check → stats → stop → inspect → start → exec verify rootfs survived → restart → rm --force → inspect-gone. Gap-fills for verbs with no `src/cli/tests/` coverage on main today: cp (binary roundtrip on a persistent rootfs path — orthogonal to the boxlite-ai#628 tmpfs surface), stats (single JSON snapshot for a running box), and negative paths (rm-running-without-force, ops on a non-existent box). Surfaces one real product gap: `boxlite logs` reads the VM/guest agent console.log (kernel + zygote + network setup tracing), NOT the container's PID-1 stdout, so a box that prints a marker via the foreground command never shows it through `logs`. The corresponding test is shipped #[ignore]d with a doc explaining what `logs` should do; removing the ignore is the gate when the gap is fixed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
G4614
force-pushed
the
fix/cp-into-runtime-mounts
branch
from
a627541 to
647832c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box lifecycle test
create->run->rm
run->exec(logs/stats/ps/cp)->rm
run->rm while exec(should be rejected)
Test plan
5 tests run via
cargo nextest run -p boxlite-cli --test lifecycle_journey --profile vm, last green: 4 PASS + 1#[ignore]d (the surfaced gap), no leftover boxes / shims.box_full_user_journey_birth_to_death(29s) — pull → run -d → ps → exec → cp host→box → exec cat verify → exec sh -c mutate → cp box→host + byte check → stats → stop → inspect (asserts"Running": false) → start → exec verify the rootfs survived stop/start → restart → rm --force → inspect-fails. A regression in any single transition surfaces here even when isolation tests pass.cp_roundtrip_persistent_path_binary_fidelity(~16s) — 257-byte payload (all 0..=255 +\n),host → box:/root/blob → host,assert_eq!(read_back, payload). Stays on/rootto keep this orthogonal to fix(guest): cp into a running box's runtime mounts (/tmp) via the container mnt ns #628's tmpfs surface.stats_json_snapshot_for_running_box(~10s) —stats --format jsonfor a running box returns a parseable JSON value.error_paths_along_the_journey(~19s) —rm-running-without-force fails;start/stop/inspect/logson a non-existent box all fail cleanly (no panic).logs_captures_box_stdout—#[ignore]d. Asserts the user-expected behavior (a box that printsMARK_LOGS_42should show it viaboxlite logs); fails onmainbecausesrc/cli/src/commands/logs.rsreadsbox_layout.console_output_path()— the VM console file (kernel + zygote + tmpfs + network tracing), not the container's PID-1 stdout. Doc comment on the test explains the gap; removing#[ignore]becomes the gate when fixed.mainsrc/cli/tests/cp*.rsempty (cp.rs / cp_runtime_mount.rs live only on this branch's previous state)cp_roundtrip_persistent_path_binary_fidelity— orthogonal binary-fidelity check on/rootstatsteststats_json_snapshot_for_running_boxtest_list_lifecyclecovers only create + list, not a composed flowpull → run → exec → cp → stop/start/restart → rmjourney asserted as one transactionlogsbehavior unassertedlogs_captures_box_stdoutdocuments the guest console vs container stdout gap + acts as the future-fix gateCenterpiece is deliberately a single composed flow so a regression at any single verb-to-verb seam fails here. The
logsfinding is the kind of thing a journey-style test catches that a feature-PR test plan never does — shipped#[ignore]so the CI is green onmaintoday, while the doc keeps the gap visible for the eventual fix.