[codex] Fix API image production build blockers#782
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThree unrelated minor fixes: the ChangesMiscellaneous Minor Fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
box_public_request: request.publiccreate-box metric after refactor(api): remove deprecated box-operation surfaces #762 moved metrics to the REST create DTO.dashboard:builddepend onapi-client:buildso clean Docker builds havedist/libs/api-clientbefore dashboard typecheck.Root cause
sst deploy --stage devfailed while building the API image. The first blocker wasapi:build:productiontypecheckingrequest.publicagainst the RESTCreateBoxDto, which intentionally has nopublicfield. After that was fixed, the same clean Docker image path exposed two dashboard production blockers: invalid generated CSS fromgap-[--spacing(var(--gap))], and a missingapi-clientbuild dependency.Validation
git diff --checkcd apps && NX_DAEMON=false yarn nx build api --configuration=production --nxBail=true --output-style=streamdocker build -f apps/api/Dockerfile --target boxlite .Notes
I checked current open PRs before opening this. #719 and #541 both touch
metrics.interceptor.ts, but neither contains this stalerequest.publicfix; #719 is also a broad draft for older API production webpack issues.Summary by CodeRabbit
Style
Chores