feat(dashboard): box table cleanup — drop region, tighten density, full image refs in onboarding#803
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR removes the ChangesBoxTable: Region → Image column replacement
Onboarding code examples: Docker image reference update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
4b70890 to
8486c41
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/dashboard/src/components/BoxTable/useBoxTable.ts`:
- Around line 79-84: The initializer function is unintentionally overwriting
persisted column visibility by always setting labels: false regardless of what
was saved in localStorage. In the useBoxTable hook, modify the logic to preserve
the user's saved visibility settings from the parsed JSON instead of spreading
it and then overwriting with hardcoded defaults. Additionally, filter out or
exclude legacy keys like region from the saved state to prevent stale visibility
entries from being restored. Only apply default values (id: true, labels: false)
for keys that do not exist in the saved state, allowing previously persisted
visibility preferences for id and labels to be respected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cbee87dd-cac9-423a-b41e-55d07d9b1f75
📒 Files selected for processing (6)
apps/dashboard/src/components/BoxTable/columns.tsxapps/dashboard/src/components/BoxTable/index.tsxapps/dashboard/src/components/BoxTable/types.tsapps/dashboard/src/components/BoxTable/useBoxTable.tsapps/dashboard/src/lib/onboarding-code-examples.tsapps/dashboard/src/pages/Boxes.tsx
💤 Files with no reviewable changes (2)
- apps/dashboard/src/components/BoxTable/types.ts
- apps/dashboard/src/pages/Boxes.tsx
…n onboarding - BoxTable: remove the Region column from the desktop table and the Region entry from the compact mobile meta. The box table no longer surfaces region. - Remove the now-unused getRegionName plumbing from the box-table path (Boxes page, BoxTable, useBoxTable, columns, types) and the stale 'region' entry from persisted column visibility. useRegions/getRegionName stay in place for the other consumers (Runners, Org Settings, Box details). - onboarding-code-examples: use the fully-qualified image reference ghcr.io/boxlite-ai/boxlite-agent-base:20260605-p0-r3 across all four SDK snippets (JS/TS, Python, Go, Rust) instead of the short 'boxlite/base'.
- BoxTable: drop the stale min-w-[1360px] (sized for removed columns) to min-w-[1120px] so the table fills the viewport without horizontal scroll, and tighten row vertical padding (py-2 -> py-1, scoped to this table) so rows are ~41px instead of ~46px. - use-mobile: lower COMPACT_BREAKPOINT 1200 -> 1024 so the dashboard keeps the full table (not the compact card layout) down to 1024px.
8486c41 to
e50f76c
Compare
… visibility Removing the Region column left a 'region: true' entry in the persisted columnVisibility localStorage that was spread back on every load. react-table ignores visibility keys without a matching column, so it was harmless cruft, but strip it on load to keep persisted state clean (CodeRabbit review).
What
Box table
min-w-[1360px](sized for now-removed columns) tomin-w-[1120px]so the table fills the viewport instead of horizontally scrolling / stretching columns.py-2→py-1, scoped to this table) so rows are ~41px instead of ~46px.getRegionNameplumbing from the box-table path and the staleregionentry in persisted column visibility.useRegions/getRegionNamestay for other consumers (Runners, Org Settings, Box details).Responsive
COMPACT_BREAKPOINT1200→1024 (use-mobile) so the dashboard keeps the full table down to 1024px instead of switching to the compact card layout at 1200px. Shared by Sidebar / Pagination / BoxTableHeader / BoxTable.Onboarding
ghcr.io/boxlite-ai/boxlite-agent-base:20260605-p0-r3across all four SDK snippets (JS/TS, Python, Go, Rust) instead of the shortboxlite/base.Scope
Frontend only. Two unrelated API errors seen during testing (
/api/regions500 dev DB drift;/api/admin/overview403 admin-probe) tracked separately.Summary by CodeRabbit
Release Notes
UI Updates
Chores