fix(dev): use current Node runtime in worktrees - #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-runtime.jsto Electron throughTX5DR_DEV_NODE_PATHContext
Source worktrees do not necessarily contain
resources/bin/<triplet>/nodebecause packaged runtime binaries are ignored build resources.dev:electronpreviously tried to launch that missing packaged path and failed withENOENTeven though the development process already had a working Node executable.The startup script now defaults the override to
process.execPath, while still allowing an explicit caller-provided path. Packaged and production runtimes continue to resolve Node from application resources.Validation
yarn workspace @tx5dr/electron-main buildyarn workspace @tx5dr/electron-main lintyarn workspace @tx5dr/electron-main test(10 files, 45 tests)node --check scripts/dev-runtime.jsgit diff --check