Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new config flag to secure the api with an apikey.
fixes #1
The apikey is generated and stored in the aws secretsmanager and checked at each client connect attempt.
The apikey can be set by adding a queryParam
apiKey=<valueFromSecret>.I decided to go with a query parameter because headers can not allways be set e.g. the browser websocket implementation does not support it.
The apiKey can be changed by altering the value of the apiKey secret.
Additionally I added an example cdk app that creates an eventbus and publishes an event every minute.