Skip to content

Conversation

@bozdoz
Copy link
Owner

@bozdoz bozdoz commented Sep 19, 2022

No description provided.

@bozdoz
Copy link
Owner Author

bozdoz commented Sep 20, 2022

@hupe13 wondering if you know if the plugin is localized; I have no clue how to get i18n working.

@hupe13
Copy link
Collaborator

hupe13 commented Sep 20, 2022

You are using _e(). When you publish the development tree (trunk) or the stable Release the translators will see this here.
I see the shortcode helper page in German, except "Reset Shortcodes", this is a new string.

Or what do you mean?

@bozdoz
Copy link
Owner Author

bozdoz commented Sep 20, 2022

No, that's what I wanted to hear! I just have no idea how the translations work. Just newly generated a .pot file; so hopefully when this gets merged, that "Reset Shortcodes" button will be updated, eventually

@hupe13
Copy link
Collaborator

hupe13 commented Sep 20, 2022

Actually you don't need a pot file at all, as far as I understand it. I do not have one in my plugin.

@bozdoz
Copy link
Owner Author

bozdoz commented Sep 20, 2022

wow, interesting

@hupe13
Copy link
Collaborator

hupe13 commented Sep 21, 2022

You are using _e().

The statement is incomplete. Must be:
You are using _e() with a text domain.

@bozdoz bozdoz changed the title feat: 2-way shortcode helper inputs; resolves #68 feat: 2-way shortcode helper inputs; resolves #68; fixes translations? Dec 30, 2022
@bozdoz
Copy link
Owner Author

bozdoz commented Dec 30, 2022

Not sure where I left off with this. I don't think I was happy with it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants