Skip to content

Add support for inline images#1287

Open
Ondama wants to merge 1 commit into
bpampuch:masterfrom
Ondama:inline-images
Open

Add support for inline images#1287
Ondama wants to merge 1 commit into
bpampuch:masterfrom
Ondama:inline-images

Conversation

@Ondama

@Ondama Ondama commented Feb 17, 2018

Copy link
Copy Markdown

This is related to #358

The result is this: fluid-layout.pdf

The source is:

const docDefinition = {
    pageSize: 'A4',
    pageMargins: [24, 25, 24, 23],
    content: [
        {text: ['hello', {image: 'smile'}, {text: 'world', style: 'em'}]}
    ],
    styles: {
        em: {bold: true}
    },
    images
}

@Ondama Ondama force-pushed the inline-images branch 2 times, most recently from f7ca60f to 5eba4ce Compare February 23, 2018 23:00
@danielpassos

Copy link
Copy Markdown

Any update on it?

@zahrafali

Copy link
Copy Markdown

Will this allow inline svg as well?

@th3impal3r

Copy link
Copy Markdown

bump this would be great!

@miroslavvojtus

Copy link
Copy Markdown

Hi.
We would need this feature. It is pretty basic feature in document editing.

Why is this PR waiting more than 2 years?
Is this lib maintained at all?

@thecodrr

thecodrr commented Jul 9, 2021

Copy link
Copy Markdown

@liborm85 ping

@Qiric

Qiric commented Nov 15, 2021

Copy link
Copy Markdown

Can't wait for this!

@Qiric

Qiric commented Nov 16, 2021

Copy link
Copy Markdown

@Ondama You don't happen to have your past solution ported over to a more recent version of pdfmake do you?

@laukacka

Copy link
Copy Markdown

@liborm85 please check it out :)

@DavMem

DavMem commented Aug 28, 2024

Copy link
Copy Markdown

thank you so much.
this still works as of today

@robbytx

robbytx commented Mar 5, 2026

Copy link
Copy Markdown

This would definitely be nice to have. In particular, the lack of inline image/SVG support prevents the use of color emojis with arbitrary text (using something like Twemoji), see foliojs/pdfkit#1056 (comment). While that might eventually be resolved by foliojs/pdfkit#1690, support for other inline images and icons that aren't official emoji characters would be desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants