fix: display HEIC/DNG/ARW/TIFF photos in non-Safari browsers#1161
Closed
vqminh wants to merge 1 commit into
Closed
fix: display HEIC/DNG/ARW/TIFF photos in non-Safari browsers#1161vqminh wants to merge 1 commit into
vqminh wants to merge 1 commit into
Conversation
Two issues fixed: 1. Convert non-browser-native formats to WebP for full-res viewing. HEIC, DNG, ARW, and TIFF files were served raw to the browser, but only Safari supports HEIC natively. Now these formats are converted to full-resolution WebP on first access and cached in TranscodedFolder. 2. Check file size when validating cached thumbnails. Previously the code used fsp.access()/fs.existsSync() which only checks existence. Failed conversions that produced 0-byte files were treated as valid thumbnails, permanently breaking those photos. Now all cache checks verify stat.size > 0.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| private static async convertedFileExists(filePath: string): Promise<boolean> { | ||
| try { | ||
| const stat = await fsp.stat(filePath); |
Owner
|
I think we do this already. or at least partially. There might be some issue when zooming in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues fixed:
Convert non-browser-native formats to WebP for full-res viewing. HEIC, DNG, ARW, and TIFF files were served raw to the browser, but only Safari supports HEIC natively. Now these formats are converted to full-resolution WebP on first access and cached in TranscodedFolder.
Check file size when validating cached thumbnails. Previously the code used fsp.access()/fs.existsSync() which only checks existence. Failed conversions that produced 0-byte files were treated as valid thumbnails, permanently breaking those photos. Now all cache checks verify stat.size > 0.