Switch to Go 1.24 (again) #439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39d118e. Signed-off-by: Andrew McDermott <[email protected]>
Signed-off-by: Andrew McDermott <[email protected]>
frobware
force-pushed
the
revert-the-revert-1.24
branch
from
909acf7 to
811d008
Compare
|
I end up typing |
|
interesting I did ask them if 4.19 can switch to go1.24 and the answer was no :) |
msherif1234
reviewed
May 9, 2025
| @@ -37,12 +37,12 @@ RUN echo "TARGETOS=${TARGETOS} TARGETARCH=${TARGETARCH} BUILDPLATFORM=${BUILDP | |||
|
|
|||
| WORKDIR /usr/src/cri-tools | |||
| ARG CRI_REPO_URL=https://github.com/kubernetes-sigs/cri-tools | |||
| ARG CRI_REPO_TAG=v1.32.0 | |||
| ARG CRI_REPO_BRANCH=master | |||
There was a problem hiding this comment.
can u pls see if they have released new version so we can use it as new pinned tag instead of master ?
Hmm. Maybe this is because we've branched for 4.20 and Go 1.24 is OK for 4.20. /hold |
|
@dave-tucker was added to my internal slack thread you can get added and check the plans for 4.19 maybe things changed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #416.
Downstream is now using Go 1.24.
The revert will also switch back
CRI_REPO_BRANCH=master.