-
Notifications
You must be signed in to change notification settings - Fork 14
chore: migrate to chai@6 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
* explicitly depend on chai and sinon where needed * wire both together using a globals.js file that is imported with the bundle * workaround tree-shaking so it is not accidentally optimized away Co-authored-by: nikku <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Please ensure we explicitly import |
Import expect from chai in test files instead of relying on globals Co-authored-by: nikku <[email protected]>
Done! Added explicit
|
a1ef10d to
7ac2b53
Compare
|
Incorporated into #76 |
Migrates from chai@4 to chai@6, following the pattern established in bpmn-js-token-simulation#176.
Changes
test/globals.jsto wire chai and sinon-chai together via chai'suse()functionsinon-chaifrom karma frameworks (now handled via explicit wiring)import { expect } from 'chai'in all test files that use chai assertionsThis explicit wiring and importing approach is required because chai@6 no longer auto-registers plugins globally in bundled environments.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.