Skip to content

Allow language context to be externally provided #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nikku
Copy link
Member

@nikku nikku commented Jan 24, 2025

Proposed Changes

When using the FeelEditor provided by properties panel folks can now inject a languageContext, to provide custom builtins, dialect and parserDialect:

<FeelLanguageContext.Provider value={ { parserDialect: 'camunda' } }>
  <FeelTextfieldComponent .../>
</FeelLanguageContext.Provider>

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku added the dependencies Updates a dependency label Jan 24, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 24, 2025
@nikku nikku changed the title Language context Allow language context to be externally provided Jan 24, 2025
@nikku nikku marked this pull request as draft January 24, 2025 14:22
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jan 24, 2025
@nikku
Copy link
Member Author

nikku commented Jan 24, 2025

Draft, because test cases are missing.

@nikku nikku added the ready Ready to be worked on label Feb 18, 2025 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Feb 18, 2025
@barmac barmac added the backlog Queued in backlog label Mar 11, 2025 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants