-
Notifications
You must be signed in to change notification settings - Fork 24
feat: allow to pass FEEL language context via context #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
03e762c
to
2506a40
Compare
2506a40
to
bfd7701
Compare
bfd7701
to
f3785c0
Compare
|
e951b0a
to
59b52fd
Compare
Thanks for addressing the merge conflicts. I'll look into this tomorrow. ✔️ |
I've added an |
Hmm the script fails due to missing context export, but it seems to be exported in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ from me on this change. Looking forward to Nico's feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
#417 (comment) is what I'd consider to change.
631a7ff
to
0671478
Compare
0671478
to
454f0f3
Compare
@Buckwich this looks like it is good to be merged 🙂 |
I didn't want to interfere with the other fixes/issues in properties panel for the current release. I'll wait to merge until those are properly integrated |
Related to camunda/camunda-modeler#4809
Proposed Changes
accept feelLanguageContext as an input for parserDialect and other feel specific fields
Test via:
(doesn't work)npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#4809-set-parser-dialect-camunda-context -l bpmn-io/properties-panel#4809-configurable-parser-dialect-context
Manually link to
bpmn-io/bpmn-js-properties-panel#4809-set-parser-dialect-camunda-context
.Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}