Make StopWindow more efficient and rename it to ConvergenceChecker#55
Open
Make StopWindow more efficient and rename it to ConvergenceChecker#55
StopWindow more efficient and rename it to ConvergenceChecker#55Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1600 1537 -63
=========================================
- Hits 1600 1537 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
bqth29
commented
Jan 12, 2024
src/simulated_bifurcation/optimizer/simulated_bifurcation_optimizer.py
Outdated
Show resolved
Hide resolved
…ted-bifurcation-algorithm into rename_stop_window
Owner
Author
|
Possible bug when combining this new window with the keyboard interrupt feature from #51: if the user stops the optimization manually between the moment when the window is reduced but not the oscillators in the optimizer, this may create shape conflicts when combining both in the final spins that are returned. Need to discuss this. |
StopWindow more efficient and rename it to ConvergenceChecker
StopWindow more efficient and rename it to ConvergenceChecker StopWindow more efficient and rename it to ConvergenceChecker
Rename "Stop Window" to "Convergence Checker"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 Pull Request Description
When the Stop Window detects that an agent has converged, it is stored in the window's memory and a boolean tensor is sent back to the optimizer to indicate which agents still have not converged. Thus, the oscillators corresponding to converged agents are removed which reduces the computation size and time.
It also becomes more relevant to rename
StopWindowasConvergenceCheckerso its purpose is more easily understandable. Documentation has been updated.Besides, the
use_windowparameter used in the various optimization functions and methods has been renamedearly_stoppingfor relevance's sake.✔️ Check list
🚀 New features
None.
🐞 Bug fixes
None.
📣 Supplementary information
None.
Renaming
StopWindowanduse_windowto respectivelyConvergenceCheckerandearly_stoppingintroduced breaking changes with respect to versions <=1.2.1.