Retrieve products and areas directly from Radar#41
Open
tonyarnold wants to merge 2 commits intobr1sk:masterfrom
Open
Retrieve products and areas directly from Radar#41tonyarnold wants to merge 2 commits intobr1sk:masterfrom
tonyarnold wants to merge 2 commits intobr1sk:masterfrom
Conversation
Also add missing properties that Radar vends.
Member
|
A while ago I did start working on a separate CLI that would generate that swift file https://github.com/br1sk/Sonar/tree/ks/genit This is probably nicer long term. This recent API change is worst case scenario, they've never changed the format of this this drastically before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this PR is actually useful, but I had a bit of a poke at dynamically retrieving the product/area list from Radar directly so that issues like #40 can be avoided in future.
I found that (as long as you have a valid token), calling https://bugreport.apple.com/developerUI/problem/getProductAreaList will get you a JSON list of products and their areas, so I added Decodable conformance to the relevant model structs and away we go!