Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your implementation. It was a helpful reference when I needed to implement Sig4 in CPP.
However there's a bug in your signature calculation code. When dealing with binary data, which can contain null characters, using strlen gives incomplete size. This was the source of a bug which took a lot of time to debug. I kept getting signature wrong responses from AWS.
Also, copy to c_string is unncessary. Strcpy is also slow. And conversion to hex can be done in a cleaner CPP style. If you don't want to incorporate these CPP style changes, I can remove them. Please let me know.
A reference for the null char issue https://stackoverflow.com/a/41601493/2382819