Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a syntax error here, the parentheses are wrong so it won't work.
after fixing it, you won't need this line:
RewriteCond $1 !^(index\.php|assets|images|js|css|uploads|favicon.png)
or you can use it alone instead.
the difference between the two that:
in the first method
the only folders (or files) that can be accessed without CodeIgniter are the ones in between the parentheses only,
any other request will route through CodeIgniter.
but in the second method:
if you put this instead, your request will went through CodeIgniter only if isn't a path to a real file/folder on your system.
for example: if you have a folder name "test" in your project
using the first one (without putting "test" inside the parentheses) will take you to "test" controller.
but if you use the second way, apache will open "test" folder.