Fix */7 day-of-week step value parsing bug #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where cron expressions with day-of-week step values ≥ 7 (like
*/7) would fail with a parsing error instead of generating the correct description.Problem
The expression
"0 * * * */7"was throwing an exception:This happened because the code was trying to convert the step value "7" to a
DayOfWeekenum value, butDayOfWeekonly accepts values 0-6 (Sunday through Saturday).Root Cause
In
ExpressionDescriptor.cs, theGetSegmentDescriptionmethod was callinggetSingleItemDescription(segments[1])for step intervals like"*/7". ThegetSingleItemDescriptionfunction tries to convert day numbers to day names using:When
expis "7", this throws an exception sinceDayOfWeekenum only supports 0-6.Solution
Modified the step interval processing in
GetSegmentDescriptionto use the raw step value directly instead of trying to convert it throughgetSingleItemDescription:Results
"0 * * * */7"now produces:"Every hour, every 7 days of the week"*/8,*/10) also work correctly1-5/2) continue to work as expectedTesting
Added test case
TestsEvery7DayOfTheWeekto prevent regression:Fixes #188.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.