Skip to content

Conversation

@puja-trivedi
Copy link
Collaborator

This PR adds a autogenerated assertion_evidence.yaml file.

@tekrajchhetri
Copy link
Contributor

tekrajchhetri commented Dec 13, 2024

Thanks @puja-trivedi for this. I observed the following.

  1. Disconnected class. Please note that these disconnected class should connect to Assertion. We could use properties, has_significance_level and has_significance (or significance_type).

image
image

  1. The assertion class should be connected to document and platform class with property is_expressed_in, which is not the case. Currently, it is connect with Thing class.

Expected:
image

Current:
image

Rest looks good to me and we can merge and this is our V1 draft.

@puja-trivedi
Copy link
Collaborator Author

puja-trivedi commented Dec 17, 2024

  • Issue 1 - Disconnected class (resolved in PR#127)
  • Issue 2 - Assertion,Document,Platform (this is an issue with the visualization tool; nothing to fix in the model)

@djarecka djarecka deleted the autogenerated-yaml-20241213195028 branch March 19, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants