Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Fix internet connection check for global accessibility #536

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

samadpls
Copy link
Contributor

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
The internet check relied on Google, which is inaccessible in some regions. This PR adds fallback URLs for global accessibility.

What does this PR do?
Adds alternative URLs (pypi.org, bing.com, gitee.com, perdu.com) to ensure connectivity checks work everywhere.

References

Fixes #522

How has this PR been tested?

  • Tested locally in environments with and without Google access.
  • Verified fallback URLs work as intended.

Is this a breaking change?

No, it maintains backward compatibility.

Does this PR require an update to the documentation?

No, functionality remains unchanged for users.

Checklist:

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samadpls!

@adamltyson adamltyson merged commit c7eea10 into brainglobe:main Mar 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check internet connection in countries without Google access.
2 participants