Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml #3

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Move to pyproject.toml #3

merged 10 commits into from
Jun 13, 2024

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Jun 13, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Remove some of our outdated config files and use pyproject.toml standard instead.

What does this PR do?

  • Moves all package metadata and installation information into pyproject.toml instead of splitting it between setup.cfg and tox.ini, etc.
  • Updates the CI to be consistent with our other packages.
  • Updates the pre-commit config and other linting files and settings.
  • Fixes a bug where the "Example QWidget" option after installing would throw an error - a command was missing from the napari.yaml file.

References

How has this PR been tested?

Local pip install -e . behaves identically to main. (Note that the widget on main remains broken, but it has the same error.)

Is this a breaking change?

Does this PR require an update to the documentation?

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Jun 13, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at some point we'd want this repo to be more consistent with napari testing setup than the brainglobe testing setup (given that this might become a napari thing one day)? But this will do for our development ease, for now.

@willGraham01 willGraham01 merged commit 11c0bd8 into main Jun 13, 2024
17 checks passed
@willGraham01 willGraham01 deleted the wgraham/move-to-pyproject branch June 13, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants