-
Notifications
You must be signed in to change notification settings - Fork 173
[Java] Remove java from the bandpass process figure #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Rewrote the HFilterDisplay function to use only native MATLAB UI components (uicontrol, axes) for displaying filter specs and responses. - Removed all Java-based UI code. - Added strip_tags helper to clean HTML from info strings for display. - Maintained dynamic resizing and layout of info panels and plots. Co-authored-by: GitHub Copilot [email protected] fix text display
Thanks @Edouard2laire for testing this and your feedback on Copilot :) I think it is something that we need to do. Have you noticed any time difference while using the uifigure versus the Brainstorm version? |
Maybe an impertinent questions, buy why do we need |
i don't think that is impertinent :) I guess it could be working with figure; but MATLAB seems to now recommend uifigure for apps: https://www.mathworks.com/help/matlab/creating_guis/modern-programmatic-app-building.html I choose uifigure here as we can use uilabels to easily display the html content. it seemed hard when using figure but there might have been ways. but since we are moving away from java, i guess it's better to move to the most modern way of doing UI. |
By App, I understand an interactive user interface, but this is static figure I agree in the |
i guess both could work, but i like UIFigure :) As you said, text could work, but you need to tune the x,y coordinates manually. Here, uigridlayout does it for us. |
The objective of this PR is to remove the Java component (that will be removed from MATLAB in a coming release -- #820) from the panel that displays the filter information.
The PR also has as objective to see how you would like to proceed with the coming depreciation of some Java components. Do we only keep the MATLAB version, or do we keep both?
This was also an occasion for me to try Copilot in VS Code. It seems to be doing ok.
The functions used here (uifigure and uilabels) were introduced in MATLAB 2016b.
Before:
After:
Note: if we want to keep more backward compatibility, then uicontrol can be used to display the text (see
c38a0b0). However, the information cannot be easily displayed in BOLD:
Regards
Edouard