Skip to content

[IO] Load kernel data#898

Merged
rcassani merged 6 commits intobrainstorm-tools:masterfrom
Edouard2laire:kernel
Mar 23, 2026
Merged

[IO] Load kernel data#898
rcassani merged 6 commits intobrainstorm-tools:masterfrom
Edouard2laire:kernel

Conversation

@Edouard2laire
Copy link
Copy Markdown
Collaborator

@Edouard2laire Edouard2laire commented Mar 10, 2026

Hello,

Those are minor fix to load nirs KERNEL data. Also remove the automatic computation of HbT as its not really usefull and can be confusing for users to see HbT even if its not present in their data.

This PR also adds support for time-domain nirs (without importing additional moments for now as i dont know how to process them yet).

Also fix unit for raw data (mV)

@rcassani
Copy link
Copy Markdown
Member

Also remove the automatic computation of HbT as its not really usefull and can be confusing for users to see HbT even if its not present in their data.

Do you thing adding a warning or other kind visual aid would help confused users?

Completely removing HbT from the NIRS montage seems to me a bit too drastic. Having HbT in the NIRS montage has been in Brainstorm for more than 10 years. As montage, it is only visual, no files are created, nor channels added in the channel file. Unless the montage is explicitly applied on the data by the user, in that case hopefully they would know what they are doing.

@Edouard2laire
Copy link
Copy Markdown
Collaborator Author

The issue is also that it doesnt work:
image

Then, if you select a channel and press =, there is no HbT:
image

Becauuse, we already compute HbT, inside nirstorm, i think this was never used. If we want the feature it should be an option like for GFP but i dont have time to add it for now (and i dont think anyone needs it -- we can check if anyone ask)

@rcassani
Copy link
Copy Markdown
Member

The issue is also that it doesnt work

Oh, that was unexpected. Let me give it a try to fix otherwise we can remove it as suggested.
Please send me NIRS file to reproduce the images shown.

Becauuse, we already compute HbT, inside nirstorm, i think this was never used.

That's true, so that montage does not have any effect in recordings that have already [HbT]

@Edouard2laire
Copy link
Copy Markdown
Collaborator Author

Edouard2laire commented Mar 17, 2026

i'll send you a file tomorrow. but i am not sure its worth fixing :) i would prefer having #897 or #894 merged before

@rcassani rcassani merged commit e96ce3e into brainstorm-tools:master Mar 23, 2026
@Edouard2laire Edouard2laire deleted the kernel branch March 23, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants