Skip to content

[io] Improve NIRS input/outputs - #937

Merged
rcassani merged 14 commits into
brainstorm-tools:masterfrom
Edouard2laire:snirf-robuist
Aug 20, 2026
Merged

[io] Improve NIRS input/outputs#937
rcassani merged 14 commits into
brainstorm-tools:masterfrom
Edouard2laire:snirf-robuist

Conversation

@Edouard2laire

@Edouard2laire Edouard2laire commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

This PR is here to slightly improve the IO for nis:

  • making the snirf reader a bit more robust to wrongly formatted snirf files
  • improve the export of the snirf file when there is no event or only one time point.
  • Port some of the fixes for reading channel files from [export bids] Adds basic NIRS support #843 (also cleaned the fix)

Once this PR is merged, I'll circle back on the read/write of BIDS datasets for nirs. (at least to make sure we can fully read nirs BIDS datasets)

Regards
Edouard

@Edouard2laire Edouard2laire changed the title [io] Improve robustness to wrongly formated snirf files [io] Improve NIRS input/outputs Aug 16, 2026
@rcassani
rcassani marked this pull request as draft August 17, 2026 13:11
@rcassani

Copy link
Copy Markdown
Member

@Edouard2laire, the PR was converted to Draft.
Please change it back once all the proposed changes are committed.

@Edouard2laire

Copy link
Copy Markdown
Collaborator Author

It’s good now

@rcassani
rcassani marked this pull request as ready for review August 17, 2026 17:24
Comment thread toolbox/io/in_tsv.m
Comment thread toolbox/io/in_fopen_bstmat.m Outdated
@rcassani

Copy link
Copy Markdown
Member

Is this commit something you need to test before merging? wip -- not tested

@Edouard2laire

Copy link
Copy Markdown
Collaborator Author

i don't really like working with table; but i think it should be ok now.

@rcassani

Copy link
Copy Markdown
Member

@Edouard2laire, Ready?

@Edouard2laire

Copy link
Copy Markdown
Collaborator Author

Yeah

@rcassani
rcassani merged commit 3aad87f into brainstorm-tools:master Aug 20, 2026
@Edouard2laire
Edouard2laire deleted the snirf-robuist branch August 20, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants