Playwright Test cases #1403

ShubhamGupta05 · 2025-12-19T04:21:59Z

Description

Main Purpose: This pull request adds Playwright test cases to enhance the end-to-end (E2E) testing capabilities for the project, ensuring that various functionalities of the Header Footer Elementor (HFE) plugin are thoroughly validated through automation.

Key Changes:

Introduced a suite of Playwright test scripts located in tests/e2e/playwright/ to facilitate automated testing of key features such as header, footer, and custom block creation.
Implemented helper functions for site login and widget activation to streamline setup processes within the tests.
Updated the package.json to include Playwright as a development dependency and defined various testing scripts for interactive, CI, and coverage scenarios.
Created Playwright configuration file playwright.config.js to specify test directory, browser projects, and testing options.
Added new test results management files and modified testing scripts to accommodate the integration of Playwright.

Additional Notes:

Reviewers should focus on the structure and implementation of the new test cases to verify that they accurately cover core functionalities of the plugin.
Ensure that all scripts for running tests (both unit and E2E) function correctly in various environments as specified.
Special attention should be given to the helpers directory, as these functions are essential for the setup of the tests and may need to be adjusted based on the testing requirements or changes in the interface of the plugin.

Screenshots

Types of changes

How has this been tested?

Checklist:

My code is tested
My code passes the PHPCS tests
My code follows accessibility standards
My code has proper inline documentation
I've included any necessary tests
I've included developer documentation
I've added proper labels to this pull request

github-actions · 2025-12-19T04:24:59Z

.claude/settings.local.json

@@ -0,0 +1,14 @@
+{


What: The JSON permissions structure seems too permissive and may grant more privileges than necessary for Bash commands.

Why: This could lead to potential security vulnerabilities, as it allows a wide range of commands that can modify or execute operations in ways that may not be intended, potentially compromising the system or application.

How: Consider restricting the permissions to only those that are absolutely necessary for your use case. For example, if 'npm install' and 'composer test' are the only required commands, list only them. Additionally, review and follow the principle of least privilege for command access.

github-actions · 2025-12-19T04:24:59Z

build/main.css

@@ -1,4 +1,10 @@
+/*!************************************************************************************************************!*\


What: The introduction of multiple comment blocks with file paths and loader information may lead to unnecessary bloat in the CSS file.

Why: While it’s useful for debugging, extensive comments in production CSS can increase file size, impacting loading times and performance. It's important to balance debug information and production efficiency.

How: Consider stripping out these extensive comments during the build process or limit their verbosity to prevent performance issues when serving the CSS in production.

github-actions · 2025-12-19T04:25:00Z

build/main.css

  font-style: normal;
  font-display: swap;
  font-weight: 400;
  src: url(/8fbf595b398521a13438.woff2) format('woff2'), url(/7d00956da27af3e30b78.woff) format('woff');


What: Each font-face declaration includes a wide unicode range, which may not be needed for all instances of the font usage.

Why: Including unnecessary characters in the unicode-range increases file size and may impact performance, especially if multiple font variations are used across the application.

How: Assess the actual characters needed for your application and limit the unicode-range to only those required, which should help optimize the file size.

github-actions · 2025-12-19T04:25:01Z

build/main.css

  font-style: italic;
  font-display: swap;
  font-weight: 400;
  src: url(/0c658d1bd687fc3b8ae1.woff2) format('woff2'), url(/f2b6d272f68d05e1513a.woff) format('woff');


What: Consider combining repeating font-face definitions by specifying multiple formats and styles within a single block.

Why: Consolidating duplicate declarations reduces redundancy in the CSS file and can simplify maintenance over time, lowering the overall CSS size and upfront parsing time for clients.

How: You can group the font-styles in one font-face rule where applicable. For example, if you have regular and italic versions of the font, declare them inside a single block with different 'font-style' or 'font-weight' attributes.

github-actions · 2025-12-19T04:25:02Z

build/main.css

 }

 :is(#hfe-settings-app, [data-floating-ui-portal]) :is(.\[\&_svg\]\:size-6 svg){
    width: 1.5rem;


What: The removal of the source map reference could hinder debugging in production environments.

Why: Source maps provide valuable debugging information for front-end developers. Without them, diagnosing UI issues could become more difficult and time-consuming.

How: If the goal is to avoid exposing the source map in production, consider maintaining the source map and only serving the CSS without it in production environments, possibly through build configurations.

github-actions · 2025-12-19T04:25:02Z

build/promotion-widget.asset.php

@@ -1 +1 @@
-<?php return array('dependencies' => array('wp-dom-ready', 'wp-element'), 'version' => '6c05e450e9d92239760e');


What: The version number in the asset file has changed without a clear accompanying reason or comment.

Why: It's important to document changes in version numbers to track what changes happened with each version, especially in a collaborative project. This helps in maintaining proper version control and understanding the impact of changes made in a plugin or component.

How: Consider adding a comment above the version line explaining the changes or reasons for this version bump to provide clarity for future developers, e.g., 'Updated version number to reflect changes made in the widget implementation.'

github-actions · 2025-12-19T04:25:03Z

build/promotion-widget.asset.php

@@ -1 +1 @@
-<?php return array('dependencies' => array('wp-dom-ready', 'wp-element'), 'version' => '6c05e450e9d92239760e');
+<?php return array('dependencies' => array('wp-dom-ready', 'wp-element'), 'version' => '618c0a71a5d4f10cfe89');


What: No significant concerns regarding security or performance are evident in this change as it only involves updating a version number; however, keep version compatibility in consideration.

Why: Compatibility between versions is crucial as it can affect how dependencies work with different versions of WordPress or the Elementor plugin. Monitoring this helps prevent potential issues in production environments.

How: Ensure that after this change, thorough testing is done across environments to check if this version works seamlessly with those dependent on it.

github-actions · 2025-12-19T04:25:04Z

build/promotion-widget.js

+
+/***/ "./src/Components/PromotionWidget.jsx":
+/*!********************************************!*\
+  !*** ./src/Components/PromotionWidget.jsx ***!


What: Potential XSS vulnerability when dynamically creating elements and inserting them into the DOM with user-controlled data. For example, the text being set via 'textContent' should be sanitized if it includes user input.

Why: This can lead to security vulnerabilities where malicious scripts can be injected and executed in the browser, impacting the application and users negatively.

How: Use a library or in-built function to sanitize user input before inserting it into the DOM. Ensure to implement appropriate escaping for any user-generated content.

github-actions · 2025-12-19T04:25:05Z

build/promotion-widget.js

+/***/ "./src/promotion-widget.js":
+/*!*********************************!*\
+  !*** ./src/promotion-widget.js ***!
+  \*********************************/


What: Use of 'setInterval' without clear cleanup can lead to memory leaks if not properly managed.

Why: If the component unmounts and the interval is not cleared, it may continue to run in the background, causing unintended behavior and performance hits.

How: Make sure to clear the interval upon component unmounting in the cleanup function of the useEffect hook.

github-actions · 2025-12-19T04:25:06Z

build/promotion-widget.js

+/******/ 			// no module.id needed
+/******/ 			// no module.loaded needed
+/******/ 			exports: {}
+/******/ 		};


What: The logic for hiding/showing buttons is quite complex and could be consolidated for better readability and maintainability.

Why: Complex conditional logic can make future modifications harder and introduce bugs when business requirements change.

How: Refactor the button visibility logic into a separate function or utility that handles showing/hiding based on the current application state.

Akshay Urankar and others added 4 commits July 29, 2025 11:13

added phpunit and e2e playwright test cases

093b8e4

Basic playwright test cases for UAE Lite

d6ca633

Added test cases for frontend actions for widgets and target rules

8014ebc

Merge branch 'release-candidate' into playwright-new-cases

7cd2e7b

ShubhamGupta05 requested review from akshayurankar48, siddharth-worlikar and sushmak02 December 19, 2025 04:22

github-actions bot reviewed Dec 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Playwright Test cases #1403

Playwright Test cases #1403

Uh oh!

ShubhamGupta05 commented Dec 19, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

github-actions bot Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,4 +1,10 @@
		/!**********************************************************************************************************!\

		@@ -1 +1 @@
		<?php return array('dependencies' => array('wp-dom-ready', 'wp-element'), 'version' => '6c05e450e9d92239760e');

Playwright Test cases #1403

Are you sure you want to change the base?

Playwright Test cases #1403

Uh oh!

Conversation

ShubhamGupta05 commented Dec 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

Types of changes

How has this been tested?

Checklist:

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShubhamGupta05 commented Dec 19, 2025 •

edited by github-actions bot

Loading