EPS-786: Fixes: Assess code quality with PHP Insights

Gruntfile.js

@@ -170,7 +170,19 @@ module.exports = function( grunt ) {
 					}
 				]
 			}
+		},
+
+		copy: {
+			main: {
+				options: {
+					mode: true
+				},
+				src: [
+					'!phpinsights.php',
+				],
+				dest: 'header-footer-elementor/'
 		}
+		},
 
 	} );
 

admin/bsf-analytics/class-bsf-analytics-loader.php

@@ -8,21 +8,20 @@
  */
 
 if ( ! defined( 'ABSPATH' ) ) {
-	exit();
+	exit;
 }
 
 /**
  * Class BSF_Analytics_Loader.
  */
 class BSF_Analytics_Loader {
-
 	/**
 	 * Analytics Entities.
 	 *
 	 * @access private
 	 * @var array Entities array.
 	 */
-	private $entities = array();
+	private $entities = [];
 
 	/**
 	 * Analytics Version.
@@ -48,33 +47,33 @@ class BSF_Analytics_Loader {
 	 */
 	private static $instance = null;
 
+	/**
+	 * Constructor
+	 */
+	public function __construct() {
+		add_action( 'init', [ $this, 'load_analytics' ] );
+	}
+
 	/**
 	 * Get instace of class.
 	 *
 	 * @return object
 	 */
 	public static function get_instance() {
-		if ( null === self::$instance ) {
+		if ( self::$instance === null ) {
 			self::$instance = new self();
 		}
 
 		return self::$instance;
 	}
 
-	/**
-	 * Constructor
-	 */
-	public function __construct() {
-		add_action( 'init', array( $this, 'load_analytics' ) );
-	}
-
 	/**
 	 * Set entity for analytics.
 	 *
 	 * @param string $data Entity attributes data.
 	 * @return void
 	 */
-	public function set_entity( $data ) {
+	public function set_entity( $data ): void {
 		array_push( $this->entities, $data );
 	}
 
@@ -83,8 +82,8 @@ public function set_entity( $data ) {
 	 *
 	 * @return void
 	 */
-	public function load_analytics() {
-		$unique_entities = array();
+	public function load_analytics(): void {
+		$unique_entities = [];
 
 		if ( ! empty( $this->entities ) ) {
 			foreach ( $this->entities as $entity ) {

admin/bsf-analytics/class-bsf-analytics-stats.php

@@ -14,7 +14,6 @@
 	 * BSF analytics stat class.
 	 */
 	class BSF_Analytics_Stats {
-
 		/**
 		 * Active plugins.
 		 *
@@ -40,7 +39,7 @@ class BSF_Analytics_Stats {
 		 * @since 1.0.0
 		 */
 		public static function instance() {
-			if ( null === self::$instance ) {
+			if ( self::$instance === null ) {
 				self::$instance = new self();
 			}
 
@@ -57,14 +56,32 @@ public function get_stats() {
 			return apply_filters( 'bsf_core_stats', $this->get_default_stats() );
 		}
 
+		/**
+		 * Format plugin data.
+		 *
+		 * @param string $plugin plugin.
+		 * @return array formatted plugin data.
+		 * @since 1.0.0
+		 */
+		public function format_plugin( $plugin ) {
+			return [
+				'name'        => html_entity_decode( $plugin['Name'], ENT_COMPAT, 'UTF-8' ),
+				'url'         => $plugin['PluginURI'],
+				'version'     => $plugin['Version'],
+				'slug'        => $plugin['TextDomain'],
+				'author_name' => html_entity_decode( wp_strip_all_tags( $plugin['Author'] ), ENT_COMPAT, 'UTF-8' ),
+				'author_url'  => $plugin['AuthorURI'],
+			];
+		}
+
 		/**
 		 * Retrieve stats for site.
 		 *
 		 * @return array stats data.
 		 * @since 1.0.0
 		 */
 		private function get_default_stats() {
-			return array(
+			return [
 				'graupi_version'         => defined( 'BSF_UPDATER_VERSION' ) ? BSF_UPDATER_VERSION : false,
 				'domain_name'            => get_site_url(),
 				'php_os'                 => PHP_OS,
@@ -99,7 +116,7 @@ private function get_default_stats() {
 
 				'active_theme'           => get_template(),
 				'active_stylesheet'      => get_stylesheet(),
-			);
+			];
 		}
 
 		/**
@@ -148,43 +165,25 @@ private function get_active_plugins() {
 
 				$plugins       = wp_get_active_and_valid_plugins();
 				$plugins       = array_map( 'get_plugin_data', $plugins );
-				$this->plugins = array_map( array( $this, 'format_plugin' ), $plugins );
+				$this->plugins = array_map( [ $this, 'format_plugin' ], $plugins );
 			}
 
 			return $this->plugins;
 		}
 
-		/**
-		 * Format plugin data.
-		 *
-		 * @param string $plugin plugin.
-		 * @return array formatted plugin data.
-		 * @since 1.0.0
-		 */
-		public function format_plugin( $plugin ) {
-			return array(
-				'name'        => html_entity_decode( $plugin['Name'], ENT_COMPAT, 'UTF-8' ),
-				'url'         => $plugin['PluginURI'],
-				'version'     => $plugin['Version'],
-				'slug'        => $plugin['TextDomain'],
-				'author_name' => html_entity_decode( wp_strip_all_tags( $plugin['Author'] ), ENT_COMPAT, 'UTF-8' ),
-				'author_url'  => $plugin['AuthorURI'],
-			);
-		}
-
 		/**
 		 * Curl SSL version.
 		 *
 		 * @return float SSL version.
 		 * @since 1.0.0
 		 */
 		private function get_curl_ssl_version() {
-			$curl = array();
+			$curl = [];
 			if ( function_exists( 'curl_version' ) ) {
 				$curl = curl_version(); // phpcs:ignore WordPress.WP.AlternativeFunctions.curl_curl_version
 			}
 
-			return isset( $curl['ssl_version'] ) ? $curl['ssl_version'] : false;
+			return $curl['ssl_version'] ?? false;
 		}
 
 		/**
@@ -198,7 +197,7 @@ private function get_curl_version() {
 				$curl = curl_version(); // phpcs:ignore WordPress.WP.AlternativeFunctions.curl_curl_version
 			}
 
-			return isset( $curl['version'] ) ? $curl['version'] : false;
+			return $curl['version'] ?? false;
 		}
 
 		/**
@@ -244,13 +243,11 @@ function wp_timezone_string() {
 
 		$offset  = (float) get_option( 'gmt_offset' );
 		$hours   = (int) $offset;
-		$minutes = ( $offset - $hours );
+		$minutes = $offset - $hours;
 
-		$sign      = ( $offset < 0 ) ? '-' : '+';
+		$sign      = $offset < 0 ? '-' : '+';
 		$abs_hour  = abs( $hours );
 		$abs_mins  = abs( $minutes * 60 );
-		$tz_offset = sprintf( '%s%02d:%02d', $sign, $abs_hour, $abs_mins );
-
-		return $tz_offset;
+		return sprintf( '%s%02d:%02d', $sign, $abs_hour, $abs_mins );
 	}
 }