Skip to content

Make userAuthenticationEmail optional for app-switch related flows #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

saperi22
Copy link
Contributor

@saperi22 saperi22 commented Mar 12, 2025

Summary of changes

  • Make userAuthenticationEmail optional for app-switch related flows

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sarahkoop
Copy link
Contributor

Is this still a draft or ready for final review? Can we confirm the "Tested and confirmed payment flows affected by this change are functioning as expected" if ready for official review

@saperi22
Copy link
Contributor Author

Is this still a draft or ready for final review? Can we confirm the "Tested and confirmed payment flows affected by this change are functioning as expected" if ready for official review

@sarahkoop
Apologies, I didn't see this message. I had to request app switch product team to enable the non-MPE flow. Testing is not complete yet.
As of today, I was able to verify the vault flow, but express checkout flow isn't enabled yet. I'm still waiting on that to be enabled before I can test it out. The code changes are done, but testing isn't complete, so I haven't opened this for review yet.

@saperi22 saperi22 marked this pull request as ready for review April 21, 2025 22:45
@saperi22 saperi22 requested a review from a team as a code owner April 21, 2025 22:45
@saperi22
Copy link
Contributor Author

Dev testing is complete.
@sarahkoop take another look if you want to. I'll merge it once you look at it.

@sarahkoop
Copy link
Contributor

Dev testing is complete. @sarahkoop take another look if you want to. I'll merge it once you look at it.

LGTM! But we should wait to merge until we have E2E testing signoff and are ready to release

@jaxdesmarais
Copy link
Contributor

➕ 1 on waiting until we get the okay from the E2E team. Ideally we can merge and release both iOS and Android at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants