Skip to content

Add required query params #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 22, 2025
Merged

Add required query params #1641

merged 12 commits into from
Aug 22, 2025

Conversation

NastassiaRodzik
Copy link
Contributor

@NastassiaRodzik NastassiaRodzik commented Aug 20, 2025 •
edited
Loading

Thank you for your contribution to Braintree.

Before submitting this PR, note we cannot accept language translation PRs. We support the same languages that are supported by PayPal, and have a dedicated localization team to provide the translations. If there is an error in a specific translation, you may open an issue and we will escalate it to the localization team.

Summary of changes

  • Added new query parameters that will be required from the PayPal app switch universal link.
  • Updated the Demo App so that we'd be able to test the Pay Later functionality.

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@NastassiaRodzik

Video

Pay later functionality on One time checkout flow:
https://github.com/user-attachments/assets/9ab4fe2f-9908-40e5-beaf-7ce725bc95b1

agedd
agedd reviewed Aug 20, 2025
View reviewed changes
agedd
agedd reviewed Aug 20, 2025
View reviewed changes
agedd
agedd approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nit comments, but otherwise looks good!

@NastassiaRodzik NastassiaRodzik marked this pull request as ready for review August 21, 2025 01:27
@NastassiaRodzik NastassiaRodzik requested a review from a team as a code owner August 21, 2025 01:27
jaxdesmarais
jaxdesmarais requested changes Aug 21, 2025
View reviewed changes
NastassiaRodzik and others added 2 commits August 21, 2025 10:23
@NastassiaRodzik @jaxdesmarais
Style guide fix
d77538d 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@NastassiaRodzik @jaxdesmarais
Style guide fix
f22e235 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
jaxdesmarais
jaxdesmarais reviewed Aug 21, 2025
View reviewed changes
@jaxdesmarais jaxdesmarais merged commit c03a90b into braintree:main Aug 22, 2025
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@agedd agedd Awaiting requested review from agedd

+1 more reviewer

@richherrera richherrera richherrera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NastassiaRodzik @jaxdesmarais @agedd @richherrera