-
Notifications
You must be signed in to change notification settings - Fork 309
[PRV2] Merge Payment Ready V2 Feature Branch #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add BTShopperInsightsClientv2 * Deprecate BTShopperInsightsClient * Add docstrings & macros validation * Fix docstring and add mark
* Add BTShopperInsightsClientv2 * Deprecate BTShopperInsightsClient * Add docstrings & macros validation * Add app installed checks and analytics events * Add unit tests for shopper insights client v2 * Add mark
* add new pagetypes * cleanup docstrings and add changelog entry
* add relevant structs and logic for CreateCustomerSession GraphQL mutation * fix lint and cocoapods warning * cleanup and address pr feedback * cleanup and address pr comments * remove typealias * address pr comments
…#1581) * Add BTCustomerRecommendationsResult file * Add BTPaymentOptions file * Add properties and docstrings * Add properties and docstrings * Update Sources/BraintreeShopperInsights/BTCustomerRecommendationsResult.swift Co-authored-by: Jax DesMarais-Leder <[email protected]> --------- Co-authored-by: Jax DesMarais-Leder <[email protected]>
* address pr feedback and add helper graphql request builder * cleanup, fix cocoapods path, address pr feedback * fix docstring for request object * cleanup and address pr feedback * cleanup * address pr feedback * Update BTCustomerSessionRequest to mimic android * Sort files * Move BTPurchaseUnit * Remove unnecessary docstrings * Update GraphQL model * Update UTs * Sort files * Move docstrings * Move docstrings * Remove unnecessary self * Update GraphQL variables * Rename payPalAppInstalled property * Use async/await instead of callback * Update UTs * Add docstring * Add teardown * Add graph ql tests * Add query assert * Update Sources/BraintreeShopperInsights/BTCustomerSessionRequest.swift Co-authored-by: Jax DesMarais-Leder <[email protected]> --------- Co-authored-by: richherrera <[email protected]> Co-authored-by: Jax DesMarais-Leder <[email protected]>
* address pr feedback and add helper graphql request builder * cleanup, fix cocoapods path, address pr feedback * fix docstring for request object * cleanup and address pr feedback * cleanup * address pr feedback * add initial structure files * Add files * Rename some properties * Change initializer process * Test async calls * Update BTCustomerSessionRequest to mimic android * Sort files * Move BTPurchaseUnit * Remove unnecessary docstrings * Update GraphQL model * Update UTs * Sort files * Move docstrings * Move docstrings * Remove unnecessary self * Remove duplicated folder * Updated GraphQLBody * Update GraphQL variables * Remove unnecessary selfs's * Pass the session ID to the GraphQL query * Update docstring * Update docstrings * Rename class * Add and fix UTs * Rename payPalAppInstalled property * Use async/await instead of callback * Update UTs * Update tests * Fix graphQL body * Update API * Add docstring * Add teardown * Add graph ql tests * Sort files * Add query assert * Add query assert * Update Sources/BraintreeShopperInsights/BTUpdateCustomerSessionAPI.swift Co-authored-by: Jax DesMarais-Leder <[email protected]> --------- Co-authored-by: ageddam <[email protected]> Co-authored-by: Jax DesMarais-Leder <[email protected]>
* cleanup, add initial file & graphql parsing logic * cleanup logic and add unit tests * re-add file and fix swiftlint warning * cleanup and address pr feedback * cleanup and address pr feedback
* add logic and unit tests * add changelog entry * add beta warning
* generateCustomerRecommendations * Add unit tests * Add a comment * Update comments * Update tests * Add changelog entry * Update name of var * Update signature to pass optional properties * Update unit test * Update unit test and comment * Update to match Android
* add payment ready v2 analytic event names * fire analytics events in the appropriate places * cleanup event names * add sanity unit tests * add last set of events * cleanup and address pr feedback * add additional details in analytic events * cleanup * add analytic checks for generate customer recs * cleanup and address pr feedback * pass in sessionID to start events * cleanup and address pr comments
* Create Shopping V2 VC * Launch V2 * Compile ready * Add updated titles * Add buttons * Add button cals for create and update customer session * Swiftlint fixes * Update buttons * Display results from PaymentReadyV2 * Toggle PayPalNetwork * Use textField properties for request * Updates to demo app * Linting issues * Send Analytics * Remove extra space * Update mapping * comment * Add recommendationLabel * Center text * Reset paypal venmo buttons when calling API’s * Remove extra progress block * swiftlint issue * Update Demo/Application/Features/ShopperInsightsViewControllerV2.swift Co-authored-by: Jax DesMarais-Leder <[email protected]> * Update Demo/Application/Features/ShopperInsightsViewControllerV2.swift Co-authored-by: Jax DesMarais-Leder <[email protected]> --------- Co-authored-by: Jax DesMarais-Leder <[email protected]>
* create v1 and v2 directory * sort files by name
# Conflicts: # CHANGELOG.md
Dependency Review✅ No vulnerabilities found.Scanned FilesNone |
jaxdesmarais
approved these changes
Sep 5, 2025
stechiu
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors