Skip to content

Conversation

stechiu
Copy link
Contributor

@stechiu stechiu commented Sep 24, 2025

Updated README to include all the payment methods we offer.

Summary of changes

  • Updated README

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner September 24, 2025 19:00
Copy link

github-actions bot commented Sep 24, 2025

Dependency Review

✅ No vulnerabilities found.

Scanned Files

None

@stechiu stechiu changed the title Update README.md Update README to list all new payment methods Sep 24, 2025
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing the data collector as well

README.md Outdated
- [ThreeDSecure](https://developer.paypal.com/braintree/docs/guides/3d-secure/overview)
- [Local Payment Methods](https://developer.paypal.com/braintree/articles/guides/payment-methods/local-payment-methods)
- [SEPA Direct Debit](https://developer.paypal.com/braintree/docs/guides/sepa-direct-debit/overview/)
- [AMEX](https://developer.paypal.com/braintree/articles/au/transactions/accepted-payment-methods#american-express)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [AMEX](https://developer.paypal.com/braintree/articles/au/transactions/accepted-payment-methods#american-express)
- [American Express](https://developer.paypal.com/braintree/articles/au/transactions/accepted-payment-methods#american-express)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if this change is necessary or a preference? I think AMEX is fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not call it AMEX in the SDK or anywhere in the dev docs, so it's important to align the naming here with what we publicly advertise as the product name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the change but we do use both Amex and American Express in both the SDK and the dev docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we call the module by the full name, we should use that here for consistency across the product: https://github.com/braintree/braintree_ios/tree/main/Sources/BraintreeAmericanExpress

@stechiu
Copy link
Contributor Author

stechiu commented Sep 25, 2025

Looks like this is missing the data collector as well

Curious why data collector should be listed as a payment method? It would be it's own separate section. I know it's one of the BT integrations but the definition and purpose of it is "DataCollector is used to collect device information to aid in fraud detection and prevention." which is why I didn't include it.

@jaxdesmarais
Copy link
Contributor

Curious why data collector should be listed as a payment method? It would be it's own separate section. I know it's one of the BT integrations but the definition and purpose of it is "DataCollector is used to collect device information to aid in fraud detection and prevention." which is why I didn't include it.

That's a good call! Since we want this to represent all features and have added Shopper Insights in this PR we should rename the header from Supported Payment Methods to Supported Payment Methods and Features so we can also add the data collector. The goal is to list everything we offer in the README where we have dev docs and aren't deprecated. This will give merchants and developers one place to see everything we offer!

@stechiu stechiu merged commit 2cca74e into main Sep 29, 2025
14 of 17 checks passed
@stechiu stechiu deleted the update-payment-methods branch September 29, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants