[v7] Update BTPayPalLineItem Parameters
#1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: the integration test suite is passing locally. |
jaxdesmarais
reviewed
Oct 8, 2025
| /// - imageURL: Optional. The URL to product image information. | ||
| /// - upcCode: Optional. UPC code for the item. | ||
| /// - upcType: Optional. UPC type for the item. Defaults to .none. | ||
| @objc(initWithQuantity:unitAmount:name:kind:unitTaxAmount:itemDescription:url:productCode:imageURL:upcCode:upcType:) |
There was a problem hiding this comment.
Do we need this or does objcMembers cover us here? We should be able to look at the interface that is built for this in Xcode. Lmk if you want me to show you how!
There was a problem hiding this comment.
ahh yep looks like objcMembers covers it for us. ty for pointing out that feature - it was pretty cool to see!
There was a problem hiding this comment.
Low key one of my favorite Xcode features 😂
saperi22
reviewed
Oct 9, 2025
jaxdesmarais
approved these changes
Oct 9, 2025
saperi22
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTPayPalLineItemproperties to have everything in the init vs using dot syntaxChecklist
Authors