Extract HTTP client logic to HttpClient and JavaHttpClient. Make Http… #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @saralvasquez, |
…Client configurable.
githubmicrob
force-pushed
the
feature/make-http-client-configurable
branch
from
a668f4d to
bf66be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Client configurable.
Summary
Extracted HTTP client functionality to separate class. Introduced HttpClient interface to make the implementation of HTTP client replaceable. In our case having another implementation is necessary because Java implementation doesn't work with HTTPS proxies.
Fix: #135
Checklist
rake test:unit)