Skip to content

Widen Activity Parameter Type #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

Widen Activity Parameter Type #118

merged 2 commits into from
Sep 29, 2025

Conversation

sshropshire
Copy link
Contributor

Summary of changes

  • This PR proposes widening the ComponentActivity reference in BraintreeClient.start() to plain Activity
  • Doing so would make BrowserSwitch more accessible to platforms like Flutter
  • ComponentActivity extends android.app.Activity so technically this should be a non-breaking change

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner September 18, 2025 21:06
@sshropshire
Copy link
Contributor Author

Hey @saperi22 and @tdchow thanks for the review! I'm working on a proof of concept for Flutter at the moment. It feels promising.

@sshropshire sshropshire merged commit dc95ebe into main Sep 29, 2025
4 checks passed
@sshropshire sshropshire deleted the widen_activity_parameter_type branch September 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdchow tdchow tdchow approved these changes

@saperi22 saperi22 saperi22 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sshropshire @tdchow @saperi22