-
Notifications
You must be signed in to change notification settings - Fork 18
Completed AuthTab Implementation #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
154e0cb
remove duplicate intent-filter
saperi22 40f85f8
- Update androidx.browser to 1.9.0
saperi22 07a38ad
first iteration on AuthTab Setup:
noguier 45f8c44
Rename .java to .kt
noguier 8eae4d4
second iteration on AuthTab Setup:
noguier 9803e43
third iteration on AuthTab Setup:
noguier e27cfa1
EOD commit:
noguier b8cfc7d
Revert "EOD commit:"
noguier e84b429
Revert "third iteration on AuthTab Setup:"
noguier 3558406
Completed implementation of AuthTab Support:
noguier 587080e
Merge remote-tracking branch 'origin/auth-tab-feature' into ana-dev
noguier af289c6
Address PR suggestions
noguier e8c5ce0
Address PR suggestions
noguier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
browser-switch/src/main/java/com/braintreepayments/api/AuthTabCallback.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.braintreepayments.api | ||
|
||
/** | ||
* Callback interface for Auth Tab results | ||
*/ | ||
fun interface AuthTabCallback { | ||
/** | ||
* @param result The final result of the browser switch operation | ||
*/ | ||
fun onResult(result: BrowserSwitchFinalResult) | ||
} |
71 changes: 71 additions & 0 deletions
71
browser-switch/src/main/java/com/braintreepayments/api/AuthTabInternalClient.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
package com.braintreepayments.api | ||
|
||
import android.content.ActivityNotFoundException | ||
import android.content.Context | ||
import android.content.Intent | ||
import android.net.Uri | ||
import androidx.activity.result.ActivityResultLauncher | ||
import androidx.annotation.VisibleForTesting | ||
import androidx.browser.auth.AuthTabIntent | ||
import androidx.browser.customtabs.CustomTabsClient | ||
import androidx.browser.customtabs.CustomTabsIntent | ||
|
||
internal class AuthTabInternalClient @VisibleForTesting constructor( | ||
private val authTabIntentBuilder: AuthTabIntent.Builder = AuthTabIntent.Builder(), | ||
private val customTabsIntentBuilder: CustomTabsIntent.Builder = CustomTabsIntent.Builder() | ||
) { | ||
|
||
|
||
tdchow marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
fun isAuthTabSupported(context: Context): Boolean { | ||
val packageName = CustomTabsClient.getPackageName(context, null) | ||
return when (packageName) { | ||
null -> false | ||
else -> CustomTabsClient.isAuthTabSupported(context, packageName) | ||
} | ||
} | ||
|
||
/** | ||
* Launch URL using Auth Tab if supported, otherwise fall back to Custom Tabs | ||
*/ | ||
@Throws(ActivityNotFoundException::class) | ||
fun launchUrl( | ||
context: Context, | ||
url: Uri, | ||
returnUrlScheme: String?, | ||
appLinkUri: Uri?, | ||
launcher: ActivityResultLauncher<Intent>, | ||
launchType: LaunchType? | ||
) { | ||
val useAuthTab = isAuthTabSupported(context) | ||
|
||
if (useAuthTab) { | ||
val authTabIntent = authTabIntentBuilder.build() | ||
|
||
if (launchType == LaunchType.ACTIVITY_CLEAR_TOP) { | ||
authTabIntent.intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP) | ||
} | ||
appLinkUri?.host?.let { host -> | ||
val path = appLinkUri.path ?: "/" | ||
authTabIntent.launch(launcher, url, host, path) | ||
} ?: returnUrlScheme?.let { | ||
authTabIntent.launch(launcher, url, returnUrlScheme) | ||
} ?: throw IllegalArgumentException("Either returnUrlScheme or appLinkUri must be provided") | ||
} else { | ||
// fall back to Custom Tabs | ||
launchCustomTabs(context, url, launchType) | ||
} | ||
} | ||
private fun launchCustomTabs(context: Context, url: Uri, launchType: LaunchType?) { | ||
val customTabsIntent = customTabsIntentBuilder.build() | ||
when (launchType) { | ||
LaunchType.ACTIVITY_NEW_TASK -> { | ||
customTabsIntent.intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | ||
} | ||
LaunchType.ACTIVITY_CLEAR_TOP -> { | ||
customTabsIntent.intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP) | ||
} | ||
null -> { } | ||
} | ||
customTabsIntent.launchUrl(context, url) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 0 additions & 38 deletions
38
browser-switch/src/main/java/com/braintreepayments/api/ChromeCustomTabsInternalClient.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.