Update CHANGELOG.md and an argument for a parametrized constructor #123
+28
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update AGP version to 8.9.1 -- requires update to gradle wrapper 8.11.1 - Update compile and target sdk to 36
added AuthTabInternalClient, removed ChromeCustomTabsInternalClient, modified ComposeActivity & DemoActivitySingleTop to accept the above changes, added toast visuals to see whether or not the AuthTab is supported
rewrote AuthTabInternalClient to Kotlin and added a ClearTop Flag, wrote new AuthTabInternalClientUnitTest, removed ChromeCustomTabsInternalClientUnitTest, modified BrowserSwitchClientUnitTest to accept the AuthTab changes
removed CustomTabIntentBuilder, removed tests associated with CustomTabs from AuthTabInternalClientUnitTest,, modified BrowserSwitchClientUnitTest to accept the AuthTab launchURL signature
-Testing the authtab flow on older devices without intents
This reverts commit e27cfa1.
This reverts commit 9803e43. Branching still needed to provide support for older devices.
- added AuthTabInternalClient, - removed ChromeCustomTabsInternalClient, - modified ComposeActivity & DemoActivitySingleTop to accept the above changes, - added toast visuals to see whether or not the AuthTab is supported
…to use AuthTab or not
-modified BrowserSwitchClient's constructor to only accept Activity as a parameter -rerouted the flow to always call completeRequest and check for the callback result withing the function -added a call to completeRequest in DemoActivitySingleTop.java onResume -added the tests to support the new flow
-removed toast pop-ups
…completeRequest() function
…ameter updated `CHANGELOG.md`
noguier
changed the title
tdchow
reviewed
Oct 15, 2025
| * @param activity The activity used to initialize the Auth Tab launcher | ||
| * @param caller The ActivityResultCaller (Activity or Fragment) used to initialize the Auth Tab launcher | ||
| */ | ||
| public void initializeAuthTabLauncher(@NonNull Activity activity) { |
There was a problem hiding this comment.
Now that this is called in the constructor, what are your thoughts on making this method private?
| * <ul> | ||
| * <li>The provided activity MUST implement {@link ActivityResultCaller}, which is true for all | ||
| * instances of {@link androidx.activity.ComponentActivity}. | ||
| * <li>The caller must be an {@link ActivityResultCaller} to register for activity results. |
There was a problem hiding this comment.
Can we also update or add a point that the constructor must be called in the activity/fragment's onCreate?
| * Add AuthTab Support | ||
| * Upgrade `androidx.browser:browser` dependency version to 1.9.0 | ||
| * Upgrade `compileSdkVersion` and `targetSdkVersion` to API 36 | ||
| * Add `AuthTabCallback` interface |
There was a problem hiding this comment.
Is the AuthTabCallback class still used with the current changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ActivityResultCalleras a parameterCHANGELOG.mdChecklist
Authors