-
Notifications
You must be signed in to change notification settings - Fork 27
Wrap WebViewClient to provide custom web view client implementation #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
saperi22
merged 11 commits into
main
from
provide-ability-for-merchant-to-override-webviewclient
Aug 12, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a503e47
Subclass WebViewClient to provide custom web view client implementation
saperi22 8f2b316
Refactor and add tests
saperi22 43cfd9b
Add custom web view client to the demo app
saperi22 1e6d7d2
clean up tests
saperi22 bb0b641
cleanup
saperi22 e6aa1bc
fixes
saperi22 af13482
add doc string
saperi22 367a22d
Use delegation instead of inheritance
saperi22 c393347
Update PopupBridge/src/test/java/com/braintreepayments/api/PopupBridg…
saperi22 d54260f
Add CHANGELOG.md entry
saperi22 57bb08e
Update CHANGELOG.md
saperi22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
PopupBridge/src/main/java/com/braintreepayments/api/PopupBridgeWebViewClient.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| package com.braintreepayments.api | ||
|
|
||
| import android.graphics.Bitmap | ||
| import android.net.http.SslError | ||
| import android.os.Build | ||
| import android.os.Message | ||
| import android.view.KeyEvent | ||
| import android.webkit.ClientCertRequest | ||
| import android.webkit.HttpAuthHandler | ||
| import android.webkit.SslErrorHandler | ||
| import android.webkit.WebResourceRequest | ||
| import android.webkit.WebResourceResponse | ||
| import android.webkit.WebView | ||
| import android.webkit.WebViewClient | ||
| import androidx.annotation.RequiresApi | ||
| import com.braintreepayments.api.internal.isVenmoInstalled | ||
|
|
||
| class PopupBridgeWebViewClient( | ||
| private val delegate: WebViewClient? = null | ||
| ) : WebViewClient() { | ||
|
|
||
| override fun onPageFinished(view: WebView?, url: String?) { | ||
| super.onPageFinished(view, url) | ||
| setVenmoInstalled(view, view?.context?.isVenmoInstalled() == true) | ||
| delegate?.onPageFinished(view, url) | ||
| } | ||
|
|
||
| @Deprecated("Deprecated in [android.webkit.WebViewClient]") | ||
| override fun shouldOverrideUrlLoading(view: WebView?, url: String?): Boolean { | ||
| return delegate?.shouldOverrideUrlLoading(view, url) ?: super.shouldOverrideUrlLoading(view, url) | ||
| } | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.N) | ||
| override fun shouldOverrideUrlLoading(view: WebView?, request: WebResourceRequest?): Boolean { | ||
| return delegate?.shouldOverrideUrlLoading(view, request) ?: super.shouldOverrideUrlLoading(view, request) | ||
| } | ||
|
|
||
| override fun onPageStarted(view: WebView?, url: String?, favicon: Bitmap?) { | ||
| delegate?.onPageStarted(view, url, favicon) ?: super.onPageStarted(view, url, favicon) | ||
| } | ||
|
|
||
| override fun onLoadResource(view: WebView?, url: String?) { | ||
| delegate?.onLoadResource(view, url) ?: super.onLoadResource(view, url) | ||
| } | ||
|
|
||
| override fun onPageCommitVisible(view: WebView?, url: String?) { | ||
| delegate?.onPageCommitVisible(view, url) ?: super.onPageCommitVisible(view, url) | ||
| } | ||
|
|
||
| override fun onReceivedError( | ||
| view: WebView?, | ||
| request: WebResourceRequest?, | ||
| error: android.webkit.WebResourceError? | ||
| ) { | ||
| delegate?.onReceivedError(view, request, error) ?: super.onReceivedError(view, request, error) | ||
| } | ||
|
|
||
| override fun onReceivedHttpError( | ||
| view: WebView?, | ||
| request: WebResourceRequest?, | ||
| errorResponse: WebResourceResponse? | ||
| ) { | ||
| delegate?.onReceivedHttpError(view, request, errorResponse) | ||
| ?: super.onReceivedHttpError(view, request, errorResponse) | ||
| } | ||
|
|
||
| override fun onFormResubmission(view: WebView?, dontResend: Message?, resend: Message?) { | ||
| delegate?.onFormResubmission(view, dontResend, resend) ?: super.onFormResubmission(view, dontResend, resend) | ||
| } | ||
|
|
||
| override fun doUpdateVisitedHistory(view: WebView?, url: String?, isReload: Boolean) { | ||
| delegate?.doUpdateVisitedHistory(view, url, isReload) ?: super.doUpdateVisitedHistory(view, url, isReload) | ||
| } | ||
|
|
||
| override fun onReceivedSslError(view: WebView?, handler: SslErrorHandler?, error: SslError?) { | ||
| delegate?.onReceivedSslError(view, handler, error) ?: super.onReceivedSslError(view, handler, error) | ||
| } | ||
|
|
||
| override fun onReceivedClientCertRequest(view: WebView?, request: ClientCertRequest?) { | ||
| delegate?.onReceivedClientCertRequest(view, request) ?: super.onReceivedClientCertRequest(view, request) | ||
| } | ||
|
|
||
| override fun onReceivedHttpAuthRequest(view: WebView?, handler: HttpAuthHandler?, host: String?, realm: String?) { | ||
| delegate?.onReceivedHttpAuthRequest(view, handler, host, realm) | ||
| ?: super.onReceivedHttpAuthRequest(view, handler, host, realm) | ||
| } | ||
|
|
||
| @Deprecated("Deprecated in [android.webkit.WebViewClient]") | ||
| override fun shouldInterceptRequest(view: WebView?, url: String?): WebResourceResponse? { | ||
| return delegate?.shouldInterceptRequest(view, url) ?: super.shouldInterceptRequest(view, url) | ||
| } | ||
|
|
||
| override fun shouldInterceptRequest(view: WebView?, request: WebResourceRequest?): WebResourceResponse? { | ||
| return delegate?.shouldInterceptRequest(view, request) ?: super.shouldInterceptRequest(view, request) | ||
| } | ||
|
|
||
| override fun onUnhandledKeyEvent(view: WebView?, event: KeyEvent?) { | ||
| delegate?.onUnhandledKeyEvent(view, event) ?: super.onUnhandledKeyEvent(view, event) | ||
| } | ||
|
|
||
| override fun onScaleChanged(view: WebView?, oldScale: Float, newScale: Float) { | ||
| delegate?.onScaleChanged(view, oldScale, newScale) ?: super.onScaleChanged(view, oldScale, newScale) | ||
| } | ||
|
|
||
| override fun onReceivedLoginRequest(view: WebView?, realm: String?, account: String?, args: String?) { | ||
| delegate?.onReceivedLoginRequest(view, realm, account, args) | ||
| ?: super.onReceivedLoginRequest(view, realm, account, args) | ||
| } | ||
|
|
||
| private fun setVenmoInstalled(view: WebView?, isVenmoInstalled: Boolean) { | ||
| runJavaScriptInWebView(view, | ||
| "" | ||
| + "function setVenmoInstalled() {" | ||
| + " window.popupBridge.isVenmoInstalled = ${isVenmoInstalled};" | ||
| + "}" | ||
| + "" | ||
| + "if (document.readyState === 'complete') {" | ||
| + " setVenmoInstalled();" | ||
| + "} else {" | ||
| + " window.addEventListener('load', function () {" | ||
| + " setVenmoInstalled();" | ||
| + " });" | ||
| + "}" | ||
| ) | ||
| } | ||
|
|
||
| private fun runJavaScriptInWebView(webView: WebView?, script: String) { | ||
| webView?.post( | ||
| Runnable { webView.evaluateJavascript(script, null) } | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.