fix async bugs and add tests#25
Merged
Merged
Conversation
Andrew Kent (realark)
force-pushed
the
ark/fix-async-bugs
branch
2 times, most recently
from
9b67f69 to
311d54f
Compare
Andrew Kent (realark)
force-pushed
the
ark/fix-async-bugs
branch
2 times, most recently
from
38e8dbc to
cbff3fd
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Jun 1, 2026
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
Member
There was a problem hiding this comment.
yeah the per session queue feels much better. nice refactor!
hooks fire and forget the event, bg worker does the http. shutdown drains queue and waits for bg worker
Andrew Kent (realark)
force-pushed
the
ark/fix-async-bugs
branch
from
cbff3fd to
01bea07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a similar architecture and test approach to what we're doing in the opencode plugin: https://github.com/braintrustdata/braintrust-opencode-plugin