Add configurable IP variables for private services & pod ranges #20
Merged
Conversation
…efault to null/previous values
JPurcell-Braintrust
requested review from
Jeff McCollum (jeffmccollum) and
Alexey Soldatchenko (soldatchenko)
Contributor
|
These changes make sense to me. Could we update the PR description to be a little more public facing and explicit about what is being introduced? i.e. "Adds optional variables for customizing the GKE pod/service IP ranges and the Private Service Access range used by Cloud SQL and Memorystore. This helps customers fit multiple Braintrust data planes into a planned GCP address space or avoid conflicts with existing peered/corporate networks. Existing defaults are preserved, so deployments that do not set these variables should see no behavior change." |
Kevin Green (KevinGreen)
approved these changes
Jun 2, 2026
Alexey Soldatchenko (soldatchenko)
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional variables for customizing the GKE pod/service IP ranges and the Private Service Access range used by Cloud SQL and Memorystore. This helps customers fit multiple Braintrust data planes into a planned GCP address space or avoid conflicts with existing peered/corporate networks.
Existing defaults are preserved, so deployments that do not set these variables should see no behavior change.