Handle attribute not being present on the weather entity#98
Open
avee87 wants to merge 1 commit into
Open
Conversation
|
Any news on this PR? |
avee87
force-pushed
the
optional-attributes
branch
from
202fe69 to
5acb76d
Compare
Author
|
Didn't realise this PR has gone stale. Rebased to the latest version. |
|
I don't think the owner accepts PRs. Or at least doesn't answer or comment. I have one PR for a year now. |
This was referenced Feb 19, 2022
|
Judging by the last commit date, this repo should be forked I guess.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes weather entity doesn't have all attributes defined. Currently card will try to render them and will only show units which looks broken.
This diff essentially makes it treat all attributes as optional and doesn't show the missing ones.