Skip to content
This repository was archived by the owner on Oct 26, 2022. It is now read-only.

Output versioned file name #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luizbon
Copy link

@luizbon luizbon commented Nov 5, 2020

Fix #43
Adding the PackageVersion parameter to the pack command will make the output file to respect it.

Fix brandedoutcast#43
Adding the PackageVersion parameter to the pack command will make the output file to respect it.
@elrhomariyounes
Copy link

I think this PR will fix also the #46

@sergeyshaykhullin
Copy link

@brandedoutcast This is a critical bug, i just pushed a wrong version =(

@drusellers
Copy link

@brandedoutcast agreed with @sergeyshaykhullin - is there anything you need to merge this?

@drusellers
Copy link

@sergeyshaykhullin I merged your pr into my own fork drusellers/publish-nuget@master FWIW

@sergeyshaykhullin
Copy link

@drusellers Can you please create a fixed release version for this changes?

@drusellers
Copy link

@sergeyshaykhullin drusellers/publish-nuget@v3 note that I've changed the syntax a bit to match other github actions and I now pass the version tag to the build as well as the publish. Feel free to open issues. :)

@gonace
Copy link

gonace commented May 13, 2021

@sergeyshaykhullin drusellers/publish-nuget@v3 note that I've changed the syntax a bit to match other github actions and I now pass the version tag to the build as well as the publish. Feel free to open issues. :)

Hi, would it be possible to merge the VERSION_STATIC functionality into your fork?

I created a fork of this project since I needed this functionality right away, sad to see the "same" project having multiple implementations, but what to do. 🤷‍♂️

Our implementation that also supports VERSION_STATIC: laget-se/[email protected]

@AraHaan
Copy link
Contributor

AraHaan commented May 20, 2021

Mind opening this PR to https://github.com/Elskom/publish-nuget/ this is my fork as well 🤣 because I needed some other changes on top of the other prs open here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Failing if a nuget package with same version already exists
6 participants