Support Git < 2.19 by dropping --column - #23
Merged
Merged
Conversation
Merged
brandonchinn178
added a commit
that referenced
this pull request
Apr 21, 2026
brandonchinn178
force-pushed
the
git-grep
branch
from
April 21, 2026 02:34
916d061 to
363fa54
Compare
brandonchinn178
force-pushed
the
git-grep
branch
from
April 21, 2026 05:30
363fa54 to
ce338e9
Compare
brandonchinn178
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--columnwas only an optimization to immediately drop everything not matching. ButelemIndexis fast enough that even the worst case of having false positives shouldn't be a big deal. And since--columnwas the only thing requiring Git > 2.19, even more reason to drop it.