feat!: Simplify error handling in the child process #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't try and serialize and send child process errors over the pipe and panic if that fails. Instead, maintain a small collection of child process exit statuses that are interpretable by the parent. This results in no underlying std::io::Errors being made available from the child but I think this may be a worthwhile tradeoff for simpler code and less syscalls/oppertunity for error and ambiguity
brannondorsey
force-pushed
the
simplify-error-handling-in-child-process
branch
from
2349927 to
668a44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try and serialize and send child process errors over the pipe and panic if that fails.
Instead, maintain a small collection of child process exit statuses that are interpret-able by the parent.
This results in no underlying
std::io::Errorsbeing made available from the child but I think this may be a worthwhile tradeoff for simpler code and less syscalls/opportunity for error and ambiguity.Because this is a breaking change we might as well lump any other breaking changes in with it. We could group this with: