Skip to content

Conversation

@Priyamanjare54
Copy link
Contributor

  • Fixed Flake8 linting issues across multiple modules (parsers, validators, main, media_processing, metadata)
  • Adjusted line lengths, indentation, and inline comments
  • Replaced star imports with explicit imports where possible
  • Ensured code is fully PEP8 compliant

Copy link
Owner

@bransoned bransoned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but there are a few things that need to be addressed:

  1. In downloaders.py some import statements need to change:
 from .media_processing import (
    write_exif,
    merge_mp4_with_overlay,
    merge_jpg_with_overlay,
    set_file_timestamp
)

# CHANGE TO:

from .media_processing import (
    merge_mp4_with_overlay,
    merge_jpg_with_overlay
)
from .metadata import(
    write_exif,
    set_file_timestamp
)
  1. Fix typo in parsers.py:
def parse_snapchat_memories0(...)

# CHANGE TO

def parse_snapchat_memories(...)
  1. Change print statement in main.py to include the entire name "MemorEasy". I know this breaks the flake8 and PEP8 compliance, but this will just need to be solved later on. I would like the script to print the entire name for now until a different solution can be created.

Other than that, everything looks pretty solid and consistent. If you can make the changes listed above and commit them to the PR, it should be good to merge with main.

@bransoned bransoned changed the title Fix Flake8 linting issues across multiple modules #37 Fix Flake8 linting issues across multiple modules Dec 24, 2025
@Priyamanjare54
Copy link
Contributor Author

All requested changes have been implemented.

@Priyamanjare54
Copy link
Contributor Author

Just checking if there’s any additional feedback on this PR. I’m happy to make further adjustments if required.

@bransoned
Copy link
Owner

Please have the logo printing in src/main.py exactly like this:

def main():

    print(r"""
███╗   ███╗███████╗███╗   ███╗ ██████╗ ██████╗ ███████╗ █████╗ ███████╗██╗   ██╗
████╗ ████║██╔════╝████╗ ████║██╔═══██╗██╔══██╗██╔════╝██╔══██╗██╔════╝╚██╗ ██╔╝
██╔████╔██║█████╗  ██╔████╔██║██║   ██║██████╔╝█████╗  ███████║███████╗ ╚████╔╝
██║╚██╔╝██║██╔══╝  ██║╚██╔╝██║██║   ██║██╔══██╗██╔══╝  ██╔══██║╚════██║  ╚██╔╝
██║ ╚═╝ ██║███████╗██║ ╚═╝ ██║╚██████╔╝██║  ██║███████╗██║  ██║███████║   ██║
╚═╝     ╚═╝╚══════╝╚═╝     ╚═╝ ╚═════╝ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═╝╚══════╝   ╚═╝
    """)

    try:
       rest of code...

Your current implementation does not print right:
image

@bransoned
Copy link
Owner

LGTM, will run builds and merge when they are successfully built.

@bransoned bransoned merged commit 09be8cf into bransoned:main Dec 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants