Skip to content

New Crowdin updates#197

Open
brave-support-admin wants to merge 190 commits into
masterfrom
l10n_master
Open

New Crowdin updates#197
brave-support-admin wants to merge 190 commits into
masterfrom
l10n_master

Conversation

@brave-support-admin

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread templates/strings/fr.toml Outdated
@github-actions

Copy link
Copy Markdown

[puLL-Merge] - brave/accounts@197

Description

Adds localization files (TOML) for ~45 new languages for email templates (verification, registration, password set/change, similar email login notifications). Also updates the existing French (fr.toml) translation: replaces "e-mail" with "courriel" (Canadian French preference), removes deprecated LoginEmailSubject/LoginEmailInstructions keys, makes VerifyEmailExpiryDisclaimer dynamic via {{.Minutes}} template variable, and fixes typographic quotes.

Possible Issues

  • Incomplete translations: Several locale files (eu.toml, hr.toml) contain English fallback text for multiple keys (e.g., SetPasswordEmailInstructions, SimilarEmailLoginMessage, PasswordChangeNotificationMessage). These will render English to users expecting Basque/Croatian.
  • French breaking change: Removing [LoginEmailSubject] and [LoginEmailInstructions] from fr.toml will cause runtime errors or missing strings if any code path still references these keys and French is the resolved locale. Verify these keys are removed from templates/code too.
  • Inconsistent copyright format: fi.toml uses "Copyright © Brave Software Inc. {{.Year}}" (year at end), while all others use "Copyright © {{.Year}} Brave Software Inc.". zh.toml uses a full-width period: "Inc。" instead of "Inc.".
  • Expiry disclaimer wording: zh.toml says "{{.Minutes}} 后失效" — missing the word for "minutes" (分钟), reading as just "after [number]" rather than "after [number] minutes".
Changes

Changes

  • templates/strings/fr.toml: Removed LoginEmailSubject and LoginEmailInstructions. Changed "e-mail" → "courriel" throughout. Made expiry disclaimer use {{.Minutes}} variable. Fixed curly quotes (''). Changed "Contacter" → "Communiquer avec". Updated copyright symbol. Reworded disregard/password-change messages.
  • templates/strings/{ar,az,bg,bn,ca,cs,da,de,el,es,et,eu,fa,fi,fil,gl,gu,he,hi,hr,hu,id,it,ja,ka,km,ko,lo,lt,lv,mk,mr,ms,nb,nl,pl,pt,ro,ru,sk,sl,sq,sr,sv,th,tr,uk,uz,vi,zh,zh-tw}.toml: New locale files, each containing 20 translation keys for email templates.
sequenceDiagram
    participant User
    participant App as Accounts Service
    participant I18n as i18n (TOML loader)
    participant Email as Email Sender

    User->>App: Request (registration/verify/password change)
    App->>I18n: Resolve locale string (e.g., "de")
    I18n->>I18n: Load templates/strings/de.toml
    I18n-->>App: Translated strings
    App->>Email: Render email with translated strings + {{.Minutes}}, {{.Email}}, {{.Year}}
    Email-->>User: Localized email delivered
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants