Skip to content

Commit

Permalink
Merge pull request #22008 from brave/issues/35520_ios
Browse files Browse the repository at this point in the history
[ads] Always run brave ads on iOS if ShouldAlwaysRunBraveAdsService true
  • Loading branch information
aseren authored Feb 13, 2024
2 parents 903510f + 029d30c commit eb622ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ public class BrowserViewController: UIViewController {
}

rewards.ads.captchaHandler = self
let shouldStartAds = rewards.ads.isEnabled || Preferences.BraveNews.isEnabled.value
let shouldStartAds = rewards.ads.isEnabled || Preferences.BraveNews.isEnabled.value || BraveAds.shouldAlwaysRunService()
if shouldStartAds {
// Only start rewards service automatically if ads is enabled
if rewards.isEnabled {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public class BraveRewards: NSObject {
private var braveNewsObservation: AnyCancellable?

private var shouldShutdownAds: Bool {
ads.isServiceRunning() && !ads.isEnabled && !Preferences.BraveNews.isEnabled.value
ads.isServiceRunning() && !ads.isEnabled && !Preferences.BraveNews.isEnabled.value && !BraveAds.shouldAlwaysRunService()
}

/// Propose that the ads service should be shutdown based on whether or not that all features
Expand Down

0 comments on commit eb622ec

Please sign in to comment.