Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8658: Tab bar interaction is broken after it becomes visible #8669

Closed
wants to merge 1 commit into from

Conversation

ns-vasilev
Copy link
Contributor

Summary of Changes

This pull request fixes brave/brave-browser#36591

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Simulator.Screen.Recording.-.iPhone.15.-.2024-01-18.at.16.59.37.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@ns-vasilev ns-vasilev requested a review from a team as a code owner January 18, 2024 16:06
@kylehickinson
Copy link
Collaborator

thanks @nik3212 but it looks like this is no longer an issue and may have been fixed at some point with some other change. Closing this as its no longer needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab bar interaction is broken after it becomes visible
2 participants