This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix compiling only necessary files during launch #8749
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR prepares for the list_catalog.json and fixes a number of issues during launch
Note except for part 2, none of this should affect launch performance. Later work will be done to improve launch performance (we will attempt to save and load dat files in the future which should give a performance boost)
Submitter Checklist:
NSLocalizableString()
Test Plan:
Test adblocking and launch performance.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement