Skip to content

Drive service saves permanent assets as drive files and renders thumbnails on listing and theme-creator #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 14, 2025
Merged

Drive service saves permanent assets as drive files and renders thumbnails on listing and theme-creator #5698

merged 12 commits into from
May 14, 2025

Conversation

Leksyk
Copy link
Contributor

@Leksyk Leksyk commented May 13, 2025 •
edited
Loading

There is a small code duplication, but I couldn't find a good place to put it in common, LMK if you have suggestions?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 78f4f3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Leksyk Leksyk requested a review from aomarks May 13, 2025 18:28
@Leksyk Leksyk changed the title WIP: Drive service saves thumbnails and renders them during listing Drive service saves permanent assets as drive files and renders thumbnails on listing and theme-creator May 14, 2025
@Leksyk Leksyk marked this pull request as ready for review May 14, 2025 22:25
dglazkov
dglazkov approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's file an issue to remove code duplication and reuse existing blob/base64 primitives we already have in @google-labs/breadboard-ai

packages/google-drive-kit/src/board-server/operations.ts
const thumbnailUrl = appProperties.thumbnailUrl;
if (thumbnailUrl) {
const thumbnailFileId = getFileId(thumbnailUrl);
const response = await retryableFetch(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically rolls all the fetches into a single call that blocks loading. Ok for now, but I think we will need to figure out how to make this go asynchronously, especially when people have a large number of boards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have a way in mind - return here and fetch from the UI layer after the list is rendered showing generic icons in meanwhile. This is how it's done in the theme generator currently.

@Leksyk Leksyk merged commit 0c7b368 into breadboard-ai:main May 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dglazkov dglazkov dglazkov approved these changes

@aomarks aomarks Awaiting requested review from aomarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leksyk @dglazkov