Smoke test rework - #7
Draft
breedx-splk wants to merge 6 commits into
Draft
Conversation
…, and only run the app in the emulator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt at reworking open-telemetry#1972 to demonstrate a separation between the test and server and app. In this rework, the test code, collector, and fake backend all run on the host machine, and only the minified app runs on the (emulated) device.
The collector is only needed to cover a gap in the fake backend, which on receives grpc and not plain http. The collector allows this translation to happen smoothly.
The
TelemetryRetrieverfetches the telemetry from the fake backend, which can support metrics, traces, and logs. For this start, we only look at traces, but would later want to expand into logs.We should discuss the pros and cons of this approach contrasted with the other approach.