Skip to content

Conversation

@anthony0030
Copy link
Contributor

On a project I'm working on, we need access to the config for the acts_as_list.
I also made sure all the tests are successful and added the appropriate tests for the new functionality that this PR adds.
It took me some time to get the DB to function, I used sqlite.
It would be great if there was some official documentation on how to set up the dev environment.
If you need any adjustments to this PR, please let me know, and I will make them ASAP.

If you accept this PR, please also publish it to Gemhub so my colleagues can easily use it.

@brendon
Copy link
Owner

brendon commented Jul 14, 2025

Hi @anthony0030, thanks for this. The dev environment can be tricky. Testing different databases relies on using ENV variables. Take a look at the GitHub Actions file for a few clues. If you'd like to put together some docs on development in a PR that would be helpful. Also, if you're only starting out with ActsAsList take a look at my other library Positioning as it might also do what you want. I'd be open to allowing configuration introspection there.

The test failures here are around needing to require logger now in older versions of rails. You can probably just require it in the test setup somewhere.

@brendon
Copy link
Owner

brendon commented Oct 19, 2025

@anthony0030 are you still wanting to pursue this?

@anthony0030
Copy link
Contributor Author

So many things have come up in the past few months. We have been using this code change on our end in production and it has been working well. what do i need to to to get this pull request murged?

@brendon
Copy link
Owner

brendon commented Oct 21, 2025

Hi @anthony0030, just get the test suite green and I can merge it. It might well work if you rebase to master.

@anthony0030
Copy link
Contributor Author

anthony0030 commented Oct 21, 2025

Hi @brendon, I rebased on master like you told me to. Also the tests seem to run locally now.

@brendon
Copy link
Owner

brendon commented Oct 21, 2025

Nice :) It all tests green. Can you add a changelog line for me in the Unreleased section please. Be sure to attribute yourself :D I can then merge and release this.

@anthony0030
Copy link
Contributor Author

Done!

@brendon brendon merged commit f3f785b into brendon:master Oct 21, 2025
54 checks passed
@brendon
Copy link
Owner

brendon commented Oct 21, 2025

Nice :) Releases as 1.2.6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants