You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found a few places in the code where function arguments were not being used, and gcc/clang was giving warnings regarding unused variables. I have commented out the variable names here to silence these warnings. I don't think these are bugs, but I definitely don't know enough about the project to be sure, so you should definitely check to see if this is really the case.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing this warning @HunterBelanger! I've removed the unused arguments and added the flag -Wextra to the workflows to make sure these warnings are caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a few places in the code where function arguments were not being used, and gcc/clang was giving warnings regarding unused variables. I have commented out the variable names here to silence these warnings. I don't think these are bugs, but I definitely don't know enough about the project to be sure, so you should definitely check to see if this is really the case.